amoeba commented on code in PR #42241:
URL: https://github.com/apache/arrow/pull/42241#discussion_r1663129893
##########
r/R/parquet.R:
##########
@@ -428,6 +428,12 @@ ParquetFileWriter <- R6Class("ParquetFileWriter",
inherit = ArrowObject,
public = list(
WriteTable = function(table, chunk_size) {
+ assert_is(table, "Table")
+ parquet___arrow___FileWriter__WriteTable(self, table, chunk_size)
+ },
+ WriteBatch = function(batch, chunk_size) {
+ assert_is(batch, "RecordBatch")
+ table <- Table$create(batch)
parquet___arrow___FileWriter__WriteTable(self, table, chunk_size)
Review Comment:
That makes plenty of sense, thanks for noticing. Fixed in
2a8fb0d9bb1113173d5eee7e7517b2b4234300c4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
