lidavidm commented on code in PR #1962:
URL: https://github.com/apache/arrow-adbc/pull/1962#discussion_r1664955780
##########
c/driver/postgresql/copy/writer.h:
##########
@@ -663,15 +766,15 @@ class PostgresCopyStreamWriter {
return NANOARROW_OK;
}
- ArrowErrorCode InitFieldWriters(ArrowError* error) {
+ ArrowErrorCode InitFieldWriters(const PostgresConnection* conn, ArrowError*
error) {
Review Comment:
nit but should we pass in the whole connection or maybe just `const
Resolver&`?
##########
c/driver/postgresql/copy/writer.h:
##########
@@ -663,15 +766,15 @@ class PostgresCopyStreamWriter {
return NANOARROW_OK;
}
- ArrowErrorCode InitFieldWriters(ArrowError* error) {
+ ArrowErrorCode InitFieldWriters(const PostgresConnection* conn, ArrowError*
error) {
Review Comment:
That might also simplify the amount of setup you have to do in the unit test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
