alamb commented on code in PR #6005:
URL: https://github.com/apache/arrow-rs/pull/6005#discussion_r1667671328
##########
arrow-array/src/builder/generic_bytes_view_builder.rs:
##########
@@ -357,6 +431,42 @@ mod tests {
use super::*;
use crate::Array;
+ #[test]
+ fn test_string_view_deduplicate() {
+ let value_1 = "long string to test string view";
+ let value_2 = "not so similar string but long";
+
+ let mut builder = StringViewBuilder::new()
+ .with_deduplicate_strings()
+ .with_block_size(value_1.len() as u32 * 2); // so that we will
have multiple buffers
Review Comment:
💯
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
