nealrichardson commented on PR #43173: URL: https://github.com/apache/arrow/pull/43173#issuecomment-2212455448
> I think this is ok, just one suggestion for something else to remove. AFAICT we only call `r_string_size` on a `STRING_ELT` from a `STRSXP`, and similarly for `utf8_string`/`utf8_strings`. `Rf_translateCharUTF8` should always work on those inputs. > > Here's the R internals version of IS_ASCII etc.; `LEVELS` is defined as `sxpinfo.gp`, an opaque bitmask. Even if this change turns out not to be correct, I don't think we want to be touching `sxpinfo.gp` for anything ourselves. https://github.com/wch/r-source/blob/0ebd0b0b574847597ac19fbf0bbbf31e3197e84b/src/include/Defn.h#L832-L853 Ah great, you've found the line in the scriptures to confirm that https://github.com/apache/arrow/issues/43044#issuecomment-2212292694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
