XiangpengHao commented on code in PR #6021:
URL: https://github.com/apache/arrow-rs/pull/6021#discussion_r1669166745
##########
parquet/src/util/bit_util.rs:
##########
@@ -461,6 +465,9 @@ impl BitReader {
match size_of::<T>() {
1 => {
let ptr = batch.as_mut_ptr() as *mut u8;
+ // SAFETY: batch is properly aligned and sized. Caller
guarantees that T
+ // can be safely seen as a slice of bytes through FromBytes
bound
+ // (FIXME: not actually true right now)
Review Comment:
`ptr` is derived from `&mut [T]`, so it is properly aligned and sized. Can
you give an example to show that this is unsound?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
