paleolimbot opened a new pull request, #1989: URL: https://github.com/apache/arrow-adbc/pull/1989
In the development version of R, calling `R_ExternalPtrAddrFn()` on an SEXP that is not an external pointer will raise an error. Because we test the error message, the order of our check vs. the call to `R_ExternalPtrAddrFn()` matters. In general, it makes more sense to do our own check first anyway! https://cran.r-project.org/web/checks/check_results_adbcdrivermanager.html ``` > test_check("adbcdrivermanager") [ FAIL 1 | WARN 0 | SKIP 3 | PASS 176 ] ══ Skipped tests (3) ═══════════════════════════════════════════════════════════ • On CRAN (3): 'test-driver_log.R:19:3', 'test-helpers.R:22:3', 'test-helpers.R:112:3' ══ Failed tests ════════════════════════════════════════════════════════════════ ── Error ('test-radbc.R:188:3'): invalid external pointer inputs generate errors ── Error in `adbc_database_init_default(driver, list(...))`: R_ExternalPtrAddrFn: argument of type STRSXP is not an external pointer ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
