kou commented on issue #43197: URL: https://github.com/apache/arrow/issues/43197#issuecomment-2216896376
Could you clarify your suggestion? The followings? * We should reject URLs that have `:password` in the "userinfo" URI part * We should reduce supported URL patterns BTW, it seems that you misinterpreted supported formats: > Apache Arrow [link](https://github.com/apache/arrow/blob/r-16.1.0/cpp/src/arrow/filesystem/azurefs.h#L138-L144) > > * Hadoop-compatible URL schemes, and > * adfs[s]://<container>:<password>@<account>.dsf.core.windows.net/path/to/file > * adfs[s]://<account>.dsf.core.windows.net/<container>/path/to/file > * adfs[s]://<password>@<account>.dsf.core.windows.net/<container>/path/to/file * Hadoop-compatible URL schemes (2. in the Arrow source), and * `adfs[s]://<container>:<password>@<account>.dsf.core.windows.net/path/to/file` (2. in the Arrow source) * `adfs[s]://<account>.dsf.core.windows.net/<container>/path/to/file` (1. in the Arrow source and Azure Data Lake Storage Gen2 compatible) * `adfs[s]://:<password>@<account>.dsf.core.windows.net/<container>/path/to/file` (`:` before `<password>` is missing and this is same as the above pattern) All of them listed by you are compatible with https://learn.microsoft.com/en-us/azure/storage/blobs/data-lake-storage-introduction-abfs-uri . "3." and "4." in the Arrow source are missed. "3." is for Azurite. It's helpful for development. "4." is for compatibility with `adlfs`, `object_store::azure` and DuckDB. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
