zeroshade commented on code in PR #1996:
URL: https://github.com/apache/arrow-adbc/pull/1996#discussion_r1670923077
##########
go/adbc/driver/flightsql/flightsql_connection.go:
##########
@@ -225,6 +225,7 @@ func (c *connectionImpl) getSessionOptions(ctx
context.Context) (map[string]inte
func (c *connectionImpl) setSessionOptions(ctx context.Context, key string,
val interface{}) error {
req := flight.SetSessionOptionsRequest{}
+ ctx = metadata.NewOutgoingContext(ctx, c.hdrs)
Review Comment:
should we use `AppendToOutgoingContext` instead? Just in case there's
already an existing context so that we're appending the headers rather than
dropping any existing ones?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
