alamb commented on code in PR #6031:
URL: https://github.com/apache/arrow-rs/pull/6031#discussion_r1671201877
##########
parquet/src/arrow/array_reader/byte_view_array.rs:
##########
@@ -316,7 +315,8 @@ impl ByteViewArrayDecoderPlain {
}
pub fn read(&mut self, output: &mut ViewBuffer, len: usize) ->
Result<usize> {
- let block_id = output.append_block(self.buf.clone().into());
+ let buf = arrow_buffer::Buffer::from_bytes(self.buf.clone().into());
Review Comment:
I think we should at least add a comment the rationale for this non obvious
code.
Maybe it would make sense to pull it into its a function (that could be
commented, and more easily discoverable)
##########
parquet/src/arrow/array_reader/byte_view_array.rs:
##########
@@ -71,7 +71,6 @@ struct ByteViewArrayReader {
}
impl ByteViewArrayReader {
- #[allow(unused)]
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
