lidavidm commented on code in PR #1998:
URL: https://github.com/apache/arrow-adbc/pull/1998#discussion_r1671407040
##########
c/driver/postgresql/copy/writer.h:
##########
@@ -92,13 +92,20 @@ class PostgresCopyFieldWriter {
public:
virtual ~PostgresCopyFieldWriter() {}
- void Init(struct ArrowArrayView* array_view) { array_view_ = array_view; };
+ template <class T, typename... Params>
+ static std::unique_ptr<T> Create(struct ArrowArrayView* array_view,
Params&&... args) {
Review Comment:
I don't think this even needs to be a static method? It could just be a free
function and you can then just invoke
```cpp
*out = MakeWriter<T>(array_view);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
