tustvold commented on code in PR #6015:
URL: https://github.com/apache/arrow-rs/pull/6015#discussion_r1672082498


##########
object_store/src/gcp/credential.rs:
##########
@@ -419,12 +422,22 @@ impl TokenProvider for InstanceCredentialProvider {
         client: &Client,
         retry: &RetryConfig,
     ) -> crate::Result<TemporaryToken<Arc<GcpCredential>>> {
-        const METADATA_IP: &str = "169.254.169.254";
-        const METADATA_HOST: &str = "metadata";
+        let metadata_host = if let Ok(host) = env::var("GCE_METADATA_HOST") {

Review Comment:
   I think it would be good to provide some links to the documentation for this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to