alamb commented on a change in pull request #9605:
URL: https://github.com/apache/arrow/pull/9605#discussion_r584686515
##########
File path: rust/datafusion/src/physical_plan/repartition.rs
##########
@@ -48,9 +51,13 @@ pub struct RepartitionExec {
input: Arc<dyn ExecutionPlan>,
/// Partitioning scheme to use
partitioning: Partitioning,
- /// Channels for sending batches from input partitions to output partitions
- /// there is one entry in this Vec for each output partition
- channels: Arc<Mutex<Vec<(Sender<MaybeBatch>, Receiver<MaybeBatch>)>>>,
+ /// Channels for sending batches from input partitions to output
partitions.
+ /// Key is the partition number
+ channels: Arc<
Review comment:
Note @Dandandan asked about using a `HashMap` vs some other structure.
It is a `HashMap` for reasons explained by @edrevo here:
https://github.com/edrevo/arrow/commit/97c256c4f76b8185311f36a7b27e317588904a3a#r47626396
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
