etseidl commented on code in PR #5486:
URL: https://github.com/apache/arrow-rs/pull/5486#discussion_r1674344471
##########
parquet/src/format.rs:
##########
@@ -634,6 +634,143 @@ impl From<&BoundaryOrder> for i32 {
}
}
+//
Review Comment:
I manually downloaded
https://github.com/apache/parquet-format/commit/40699d05bd24181de6b1457babbee2c16dce3803
and ran thrift. Then I discovered the `regen.sh` and performed the steps
therein. Yes, the `REVISION` in `regen.sh` should be updated. I'll make that
part of a new PR for the format changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]