zanmato1984 commented on code in PR #43226:
URL: https://github.com/apache/arrow/pull/43226#discussion_r1674441698


##########
cpp/src/arrow/compute/row/encode_internal.cc:
##########
@@ -160,8 +161,8 @@ Status RowTableEncoder::EncodeSelected(RowTableImpl* rows, 
uint32_t num_selected
                         
/*num_extra_bytes_to_append=*/static_cast<uint32_t>(0)));
   // Then populate the offsets of the var-length columns, which will be used 
as the target
   // size of the var-length buffers resizing below.
-  EncoderOffsets::GetRowOffsetsSelected(rows, batch_varbinary_cols_, 
num_selected,
-                                        selection);
+  RETURN_NOT_OK(EncoderOffsets::GetRowOffsetsSelected(rows, 
batch_varbinary_cols_,

Review Comment:
   This is what I've been always curious about as my question in #43209. If 
anyone sees this and comment on #43209, I'll be much appreciated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to