zanmato1984 commented on issue #43209: URL: https://github.com/apache/arrow/issues/43209#issuecomment-2223561647
> The general convention is that when you are utilizing this from _outside_ of internal Arrow code, you should use `ARROW_DCHECK_*` to indicate where the macro is coming from. This is the same convention for the `RETURN_NOT_OK` vs `ARROW_RETURN_NOT_OK` family of functions. > > At least that's my understanding. Thanks @zeroshade , that makes much sense. If this is the case, then we should probably put some comments around these macros as a tiny coding guideline. Let's wait for a while to see if others have any further comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
