alamb commented on code in PR #6045:
URL: https://github.com/apache/arrow-rs/pull/6045#discussion_r1676801929
##########
parquet/src/format.rs:
##########
@@ -3417,10 +3565,15 @@ pub struct ColumnMetaData {
/// Writers should write this field so readers can read the bloom filter
/// in a single I/O.
pub bloom_filter_length: Option<i32>,
+ /// Optional statistics to help estimate total memory when converted to
in-memory
Review Comment:
An alternative would be to make a feature branch that we could target /
review PRs to, and then I could merge the feature branch to main when ready.
@XiangpengHao, @Weijun-H, and I took this approach for StringView in DataFusion
and it worked well in my opinion
What worked well, is that it enabled me to review the PRs faster (as smaller
PRs require less contiguous time for review, and thus I am able to do them
faster)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
