paleolimbot commented on code in PR #448:
URL: https://github.com/apache/arrow-nanoarrow/pull/448#discussion_r1677925130
##########
ci/scripts/build-arrow-cpp-minimal.sh:
##########
@@ -45,10 +45,10 @@ ARROW_CPP_SCRATCH_DIR="arrow-cpp-build-${ARROW_CPP_VERSION}"
mkdir "${ARROW_CPP_SCRATCH_DIR}"
pushd "${ARROW_CPP_SCRATCH_DIR}"
-curl -L
"https://www.apache.org/dyn/closer.lua?action=download&filename=arrow/arrow-${ARROW_CPP_VERSION}/apache-arrow-${ARROW_CPP_VERSION}.tar.gz";
| \
+curl -L "https://github.com/apache/arrow/archive/refs/heads/main.tar.gz"; | \
tar -zxf -
mkdir build && cd build
-cmake ../apache-arrow-${ARROW_CPP_VERSION}/cpp \
+cmake ../arrow-main/cpp \
Review Comment:
Will the Arrow 17.0.0 release include the upstream changes required to make
this work? We can't merge this particular change but we can update the version
we use in CI once released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
