alamb commented on pull request #9608: URL: https://github.com/apache/arrow/pull/9608#issuecomment-788388761
@NGA-TRAN there appears to be a clippy failuire: https://github.com/apache/arrow/pull/9608/checks?check_run_id=2007813369 ``` error: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name --> datafusion/src/logical_plan/expr.rs:446:20 | 446 | pub fn is_null(self) -> Expr { | ^^^^ | = note: `-D clippy::wrong-self-convention` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention error: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name --> datafusion/src/logical_plan/expr.rs:451:24 | 451 | pub fn is_not_null(self) -> Expr { | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention ``` I think given what we are doing (mirroring the expression names rather than actually implementing Idiomatic Rust conversions), annotating those functions with something like ``` #[allow(clippy::wrong-self-convention)] ``` is probably the best approach ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
