sundy-li commented on a change in pull request #9602:
URL: https://github.com/apache/arrow/pull/9602#discussion_r585214440
##########
File path: rust/arrow/src/compute/kernels/sort.rs
##########
@@ -36,8 +36,12 @@ use TimeUnit::*;
///
/// Returns an `ArrowError::ComputeError(String)` if the array type is either
unsupported by `sort_to_indices` or `take`.
///
-pub fn sort(values: &ArrayRef, options: Option<SortOptions>) ->
Result<ArrayRef> {
- let indices = sort_to_indices(values, options)?;
+pub fn sort(
+ values: &ArrayRef,
+ options: Option<SortOptions>,
+ limit: Option<usize>,
Review comment:
Ok, I will introduce `partial_sort` with `limit` parameter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
