zanmato1984 commented on code in PR #43278:
URL: https://github.com/apache/arrow/pull/43278#discussion_r1680429003


##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -779,9 +779,9 @@ class InputState {
   // Hasher for key elements
   mutable KeyHasher* key_hasher_;
   // Owning node

Review Comment:
   ```suggestion
   #ifndef NDEBUG
     // Owning node
   ```



##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -779,9 +779,9 @@ class InputState {
   // Hasher for key elements
   mutable KeyHasher* key_hasher_;
   // Owning node
-  AsofJoinNode* node_;
+  [[maybe_unused]] AsofJoinNode* node_;

Review Comment:
   ```suggestion
     AsofJoinNode* node_;
   ```



##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -779,9 +779,9 @@ class InputState {
   // Hasher for key elements
   mutable KeyHasher* key_hasher_;
   // Owning node
-  AsofJoinNode* node_;
+  [[maybe_unused]] AsofJoinNode* node_;
   // Index of this input
-  size_t index_;
+  [[maybe_unused]] size_t index_;

Review Comment:
   ```suggestion
     size_t index_;
   #endif
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to