etseidl commented on code in PR #6068: URL: https://github.com/apache/arrow-rs/pull/6068#discussion_r1681794975
########## parquet/src/file/page_index/offset_index.rs: ########## @@ -0,0 +1,50 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! [`OffsetSizeIndex`] structure holding decoded [`OffsetIndex`] information + +use crate::errors::ParquetError; +use crate::format::{OffsetIndex, PageLocation}; + +/// [`OffsetIndex`] information for a column chunk. Contains offsets and sizes for each page +/// in the chunk. Optionally stores fully decoded page sizes for BYTE_ARRAY columns. +#[derive(Debug, Clone, PartialEq)] +pub struct OffsetSizeIndex { Review Comment: It was `ParquetOffsetIndex` in my original PR, but then that collides with the typedef in `file/metadata/mod.rs`. As I write this, I'm wondering if we need this struct at all. The current `read_pages_locations` returns the thrift struct. `OffsetIndex` has the same data members as `OffsetSizeIndex`, so is it worth defining a new struct? It seems there's precedent for using the thrift objects from `format` elsewhere in the metadata. Failing that, how about `OffsetIndexMetaData`? That seems more in line with the naming of the rest of the footer objects in `file::metadata`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
