pitrou commented on code in PR #42174:
URL: https://github.com/apache/arrow/pull/42174#discussion_r1682989125
##########
cpp/tools/parquet/CMakeLists.txt:
##########
@@ -32,5 +32,16 @@ if(PARQUET_BUILD_EXECUTABLES)
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR})
endforeach(TOOL)
+ # Only build parquet-dump-footer when statically linking.
Review Comment:
No, as I said, you can instead Thrift-manipulating functions from this
executable into libparquet as internal APIs. Then you don't need to access
Thrift internals here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
