lidavidm commented on code in PR #2025:
URL: https://github.com/apache/arrow-adbc/pull/2025#discussion_r1683603992
##########
go/adbc/driver/snowflake/bulk_ingestion.go:
##########
@@ -45,7 +45,7 @@ import (
const (
bindStageName = "ADBC$BIND"
- createTemporaryStageStmt = "CREATE OR REPLACE TEMPORARY STAGE " +
bindStageName + " FILE_FORMAT = (TYPE = PARQUET USE_LOGICAL_TYPE = TRUE
BINARY_AS_TEXT = FALSE)"
+ createTemporaryStageStmt = "CREATE OR REPLACE TEMPORARY STAGE " +
bindStageName + " FILE_FORMAT = (TYPE = PARQUET USE_LOGICAL_TYPE = TRUE
BINARY_AS_TEXT = FALSE USE_VECTORIZED_SCANNER=TRUE REPLACE_INVALID_CHARACTERS =
TRUE)"
Review Comment:
Is it necessary to set REPLACE_INVALID_CHARACTERS? I guess Snowflake
recommends it "as a general rule of thumb" but I wonder why...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
