lidavidm commented on a change in pull request #9616:
URL: https://github.com/apache/arrow/pull/9616#discussion_r585749637
##########
File path: cpp/src/arrow/dataset/dataset.h
##########
@@ -43,7 +43,7 @@ namespace dataset {
/// Note that Fragments have well defined physical schemas which are
reconciled by
/// the Datasets which contain them; these physical schemas may differ from a
parent
/// Dataset's schema and the physical schemas of sibling Fragments.
-class ARROW_DS_EXPORT Fragment {
+class ARROW_DS_EXPORT Fragment : public std::enable_shared_from_this<Fragment>
{
Review comment:
A further improvement would be to also expose `std::string
Fragment::name()` or similar for logging purposes; file fragments would return
the filename, while other fragments would return some fixed identifier (much
like type_name).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
