bkietz commented on code in PR #562:
URL: https://github.com/apache/arrow-nanoarrow/pull/562#discussion_r1684922238
##########
r/src/materialize_unspecified.h:
##########
@@ -33,27 +33,26 @@ static inline int nanoarrow_materialize_unspecified(struct
ArrayViewSlice* src,
int* result = LOGICAL(dst->vec_sexp);
- int64_t total_offset = src->array_view->array->offset + src->offset;
- int64_t length = src->length;
- const uint8_t* bits = src->array_view->buffer_views[0].data.as_uint8;
-
- if (length == 0 || src->array_view->storage_type == NANOARROW_TYPE_NA ||
- ArrowBitCountSet(bits, total_offset, length) == 0) {
+ if (ArrowArrayViewComputeNullCount(src->array_view) == src->length) {
Review Comment:
I'll remove this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
