thisisnic commented on code in PR #43338:
URL: https://github.com/apache/arrow/pull/43338#discussion_r1685328403
##########
r/R/arrow-tabular.R:
##########
@@ -48,13 +48,13 @@ ArrowTabular <- R6Class("ArrowTabular",
SortIndices = function(names, descending = FALSE) {
assert_that(is.character(names))
assert_that(length(names) > 0)
- assert_that(!any(is.na(names)))
+ assert_that(!anyNA(names))
Review Comment:
Hadn't heard of `anyNA()` before, nice.
##########
r/tests/testthat/test-dplyr-funcs-conditional.R:
##########
@@ -30,7 +30,7 @@ test_that("if_else and ifelse", {
compare_dplyr_binding(
.input %>%
mutate(
- y = if_else(int > 5, 1, 0),
+ y = as.integer(int > 5),
Review Comment:
The changes in these tests are incorrect as they completely change what is
being tested here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
