raulcd commented on code in PR #43281: URL: https://github.com/apache/arrow/pull/43281#discussion_r1686495755
########## python/MANIFEST.in: ########## @@ -6,6 +6,11 @@ global-include CMakeLists.txt graft pyarrow graft cmake_modules +prune benchmarks +prune cmake_modules +prune examples +prune scripts Review Comment: This looks good to me but I honestly prefer the changes here: https://github.com/apache/arrow/pull/43325/files If we add a new folder or some of those existing ones get removed we don't have to update anything, but we would have to update `MANIFEST.in` every time, so the changes there feel more future proof to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
