mapleFU commented on code in PR #37400:
URL: https://github.com/apache/arrow/pull/37400#discussion_r1686775297
##########
cpp/src/parquet/arrow/arrow_reader_writer_test.cc:
##########
@@ -5419,10 +5421,17 @@ class ParquetPageIndexRoundTripTest : public
::testing::Test {
ASSERT_OK_AND_ASSIGN(buffer_, sink->Finish());
}
+ protected:
+ std::shared_ptr<Buffer> buffer_;
+};
+
+class ParquetPageIndexRoundTripTest : public ::testing::Test,
+ public ParquetIndexRoundTripTest {
+ public:
void ReadPageIndexes(int expect_num_row_groups, int expect_num_pages,
const std::set<int>& expect_columns_without_index = {})
{
auto read_properties = default_arrow_reader_properties();
- auto reader =
ParquetFileReader::Open(std::make_shared<BufferReader>(buffer_));
+ auto reader =
ParquetFileReader::Open(std::make_shared<BufferReader>(this->buffer_));
Review Comment:
Anyway I'm customed to `this`, this is not required but I also think we
don't need remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
