adriangb commented on code in PR #6000:
URL: https://github.com/apache/arrow-rs/pull/6000#discussion_r1687077115
##########
parquet/src/file/writer.rs:
##########
@@ -814,20 +734,289 @@ impl<'a, W: Write + Send> PageWriter for
SerializedPageWriter<'a, W> {
}
}
+struct ThriftMetadataWriter<'a, W: Write> {
+ buf: &'a mut TrackedWrite<W>,
+ schema: &'a TypePtr,
+ schema_descr: &'a SchemaDescPtr,
+ row_groups: Vec<RowGroup>,
Review Comment:
I agree, but lets do that in a followup PR since (I think) that would not be
breaking in any way and this is quite large already
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
