jorisvandenbossche commented on PR #43325:
URL: https://github.com/apache/arrow/pull/43325#issuecomment-2245429435

   @raulcd thanks for working on this! We should have tested that on the 
original PR .. 
   
   There is still some code in `setup.py` to define `packages`, which can be 
cleaned up. Given that this code is still there, and from looking back at the 
discussion in https://github.com/apache/arrow/pull/41041, I think we assumed 
that this would still work (i.e. moved most info to pyproject.toml, but leave 
`packages` definition in setup.py). 
   Because for example we have the `PYARROW_INSTALL_TESTS` env variable to 
allow removing the tests from the packages (but it seems we only use that in 
our CI turned on, and not turned off .. so this "feature" also broke in 17.0 I 
assume)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to