V0ldek commented on issue #6099: URL: https://github.com/apache/arrow-rs/issues/6099#issuecomment-2247807084
I proposed the `flush` method in #6108, it's a small change. Actually I think the buffering change can be done without a breaking change? 1. The `try_new` and `try_new_with_options` would not wrap the `Writer` in the `BufWrite`. This is not a breaking change as the `writer` field is private and never exposed directly. 2. We can add `try_new_buffered` as a convenience method to create `StreamWriter<BufWriter<W>>` directly. A cosmetic issue is that this is inverted wrt. the `reader` API. But maybe it should be that way for `reader` as well? As in, remove `try_new_unbuffered` from reader and switch so that the default is unbuffered? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
