joellubi commented on code in PR #43234: URL: https://github.com/apache/arrow/pull/43234#discussion_r1689746340
########## go/arrow/extensions/bool8.go: ########## @@ -0,0 +1,196 @@ +package extensions + +import ( + "fmt" + "reflect" + "strconv" + "strings" + + "github.com/apache/arrow/go/v17/arrow" + "github.com/apache/arrow/go/v17/arrow/array" + "github.com/apache/arrow/go/v17/arrow/memory" + "github.com/apache/arrow/go/v17/internal/json" +) + +const ExtensionNameBool8 = "bool8" Review Comment: I removed this const entirely because it's only used in one place (in the `Bool8Type.ExtensionName` impl) and it's simple enough to just get the type itself, which is exported, and just call `ExtensionName()` if needed. I'll also leave out auto-registering canonical extensions for now. Once Opaque merges and UUID gets moved out of `internal`, we can set that up for them together. FYI all subsequent code changes are in #43323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
