jonkeane commented on code in PR #43351:
URL: https://github.com/apache/arrow/pull/43351#discussion_r1689779239
##########
r/src/arrow_cpp11.h:
##########
@@ -138,7 +138,12 @@ inline R_xlen_t r_string_size(SEXP s) {
} // namespace unsafe
inline SEXP utf8_strings(SEXP x) {
- return cpp11::unwind_protect([x] {
+ return cpp11::unwind_protect([&] {
+ // ensure that x is not actually altrep first
+ bool was_altrep = ALTREP(x);
+ if (was_altrep) {
+ x = PROTECT(Rf_duplicate(x));
Review Comment:
Yeah, I'll expand what I have there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
