jorisvandenbossche commented on code in PR #43392:
URL: https://github.com/apache/arrow/pull/43392#discussion_r1690077249
##########
python/pyarrow/_cuda.pyx:
##########
@@ -185,6 +185,12 @@ cdef class Context(_Weakrefable):
cudabuf = GetResultValue(self.context.get().Allocate(nbytes))
return pyarrow_wrap_cudabuffer(cudabuf)
+ def memory_manager(self):
Review Comment:
Can you add a brief docstring for both attributes? (you can probably just
copy what we added for those attributes elsewhere, e.g. on the Buffer class)
##########
python/pyarrow/_cuda.pyx:
##########
@@ -185,6 +185,12 @@ cdef class Context(_Weakrefable):
cudabuf = GetResultValue(self.context.get().Allocate(nbytes))
return pyarrow_wrap_cudabuffer(cudabuf)
+ def memory_manager(self):
Review Comment:
Ah, and I would make those properties instead of methods?
At least that's what we did on Buffer and Array. I think it makes most sense
to be consistent here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
