alamb commented on code in PR #6116:
URL: https://github.com/apache/arrow-rs/pull/6116#discussion_r1691875652
##########
arrow/Cargo.toml:
##########
@@ -75,7 +75,7 @@ pyarrow = ["pyo3", "ffi"]
# force_validate runs full data validation for all arrays that are created
# this is not enabled by default as it is too computationally expensive
# but is run as part of our CI checks
-force_validate = ["arrow-data/force_validate"]
+force_validate = ["arrow-array/force_validate", "arrow-data/force_validate"]
Review Comment:
There was code in `arrow-data` that was enabled by the `force_validate`
config setting, but `arrow-data` doesn't actually have that feature
##########
arrow-array/src/array/string_array.rs:
##########
@@ -376,70 +376,6 @@ mod tests {
.expect("All null array has valid array data");
}
- #[cfg(feature = "test_utils")]
Review Comment:
This code also doesn't compile even when I added a `test_utils` feature flag
-- I think it is left over from a time before we broke the crates apart
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
