paleolimbot commented on issue #566: URL: https://github.com/apache/arrow-nanoarrow/issues/566#issuecomment-2251332256
We could certainly replicate Arrow C++'s syntax here, although I am hesitant to add scope to nanoarrow or make it seem like we are trying to replace anything about Arrow C++. > This should include a schema equality utility too We have a few places that do something like this...for integration testing we have one that is slow (and somewhat specific to the types of schemas that show up in the integration testing) but generates a nice diff: https://github.com/apache/arrow-nanoarrow/blob/2040e74add0a3c8a36877bce35c7dc43c27ba0e4/src/nanoarrow/integration/c_data_integration.cc#L151-L162 ...and in Python we have one (that should almost certainly be written in C) that performs the check but doesn't generate very useful output on failure: https://github.com/apache/arrow-nanoarrow/blob/2040e74add0a3c8a36877bce35c7dc43c27ba0e4/python/src/nanoarrow/_schema.pyx#L349-L402 Both of those are pretty specific to exactly what we needed them for. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
