WillAyd commented on code in PR #1965: URL: https://github.com/apache/arrow-adbc/pull/1965#discussion_r1693232518
########## r/adbcdrivermanager/configure: ########## @@ -25,28 +25,28 @@ if [ -f bootstrap.R ]; then $R_HOME/bin/Rscript bootstrap.R --vanilla fi -if [ -f "src/adbc.h" ] && [ -f "src/adbc_driver_manager.h" ] && [ -f "src/adbc_driver_manager.cc" ]; then +if [ -f "src/arrow-adbc/adbc.h" ] && [ -f "src/arrow-adbc/adbc_driver_manager.h" ] && [ -f "src/adbc_driver_manager.cc" ]; then echo "Found vendored ADBC" exit 0 fi # We have a situation where the package has been built via R CMD build # manually or with pkgbuild <=1.4.0. This is common (e.g., pak::pkg_install() # or remotes::install_github() or any dependency setups that use either method) -curl -L https://github.com/apache/arrow-adbc/raw/main/adbc.h \ - --output src/adbc.h --silent -curl -L https://github.com/apache/arrow-adbc/raw/main/c/driver_manager/adbc_driver_manager.h \ - --output src/adbc_driver_manager.h --silent +curl -L https://github.com/WillAyd/arrow-adbc/raw/fix-adbc-include/c/include/arrow-adbc/adbc.h \ Review Comment: @paleolimbot thanks for all of the help here. Do you think this change is still required? Not sure how to best manage this script when the location of these files change relative to main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
