paleolimbot commented on issue #567:
URL:
https://github.com/apache/arrow-nanoarrow/issues/567#issuecomment-2253475445
It's worth noting that we don't have an `ArrowError` everywhere we might
want a stacktrace (e.g., functions that can only fail with `ENOMEM` tend to not
accept an `ArrowError*`). Basically everywhere we do a `return <something that
is not NANOARROW_OK>` should maybe turn into `ERROR_RETURN(<something that is
not NANOARROW_OK>)`. The whole stack is nice but even just knowing where the
first one was lets you set a breakpoint.
> but that's probably not desirable because we'd need to add
ArrowError{Init,Reset} everywhere.)
Yes, I think that would be disruptive (although some day it might be the
right move, as a 1023 character error might be limiting eventually).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
