mapleFU commented on code in PR #43445:
URL: https://github.com/apache/arrow/pull/43445#discussion_r1693881220
##########
cpp/src/arrow/util/binary_view_util.h:
##########
@@ -26,6 +26,7 @@
namespace arrow::util {
inline BinaryViewType::c_type ToInlineBinaryView(const void* data, int32_t
size) {
+ assert(size <= BinaryViewType::kInlineSize);
Review Comment:
https://godbolt.org/z/q8xjb8Ehe
From here, COMPILER ASSUMER might generate better code in C++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
