alamb commented on code in PR #6071:
URL: https://github.com/apache/arrow-rs/pull/6071#discussion_r1693936382
##########
arrow-arith/src/temporal.rs:
##########
@@ -1500,4 +1595,203 @@ mod tests {
ensure_returns_error(&Time64MicrosecondArray::from(vec![0]));
ensure_returns_error(&Time64NanosecondArray::from(vec![0]));
}
+
+ // IntervalDayTimeType week, day, hour, miute, second, mili, u, nano;
invalid month, year; ignores the other part
+ // IntervalMonthDayNanoType year -> nano; days don't affect months, time
doesn't affect days, time doesn't affect months (and vice versa)
+ #[test]
+ fn test_interval_year_month_array() {
+ let input: IntervalYearMonthArray = vec![0, 5, 24].into();
+
+ let actual = date_part(&input, DatePart::Year).unwrap();
+ let actual = actual.as_primitive::<Int32Type>();
+ assert_eq!(0, actual.value(0));
+ assert_eq!(0, actual.value(1));
+ assert_eq!(2, actual.value(2));
+
+ let actual = date_part(&input, DatePart::Month).unwrap();
+ let actual = actual.as_primitive::<Int32Type>();
+ assert_eq!(0, actual.value(0));
+ assert_eq!(5, actual.value(1));
+ assert_eq!(0, actual.value(2));
+
+ assert!(date_part(&input, DatePart::Day).is_err());
+ assert!(date_part(&input, DatePart::Week).is_err());
+ }
+
+ #[test]
+ fn test_interval_day_time_array() {
+ let input: IntervalDayTimeArray = vec![
+ IntervalDayTime::ZERO,
+ IntervalDayTime::new(10, 42),
+ IntervalDayTime::new(10, 1042),
+ IntervalDayTime::new(10, MILLISECONDS_IN_DAY as i32 + 1),
+ ]
+ .into();
+
+ // Time doesn't affect days.
+ let actual = date_part(&input, DatePart::Day).unwrap();
+ let actual = actual.as_primitive::<Int32Type>();
+ assert_eq!(0, actual.value(0));
+ assert_eq!(10, actual.value(1));
+ assert_eq!(10, actual.value(2));
+ assert_eq!(10, actual.value(3));
+
+ let actual = date_part(&input, DatePart::Week).unwrap();
+ let actual = actual.as_primitive::<Int32Type>();
+ assert_eq!(0, actual.value(0));
+ assert_eq!(1, actual.value(1));
+ assert_eq!(1, actual.value(2));
+ assert_eq!(1, actual.value(3));
+
+ // Days doesn't affect time.
+ let actual = date_part(&input, DatePart::Nanosecond).unwrap();
+ let actual = actual.as_primitive::<Int32Type>();
+ assert_eq!(0, actual.value(0));
+ assert_eq!(42_000_000, actual.value(1));
+ assert_eq!(1_042_000_000, actual.value(2));
+ // Overflow returns zero.
+ assert_eq!(0, actual.value(3));
+
+ let actual = date_part(&input, DatePart::Microsecond).unwrap();
+ let actual = actual.as_primitive::<Int32Type>();
+ assert_eq!(0, actual.value(0));
+ assert_eq!(42_000, actual.value(1));
+ assert_eq!(1_042_000, actual.value(2));
+ // Overflow returns zero.
+ assert_eq!(0, actual.value(3));
+
+ let actual = date_part(&input, DatePart::Millisecond).unwrap();
+ let actual = actual.as_primitive::<Int32Type>();
+ assert_eq!(0, actual.value(0));
+ assert_eq!(42, actual.value(1));
+ assert_eq!(1042, actual.value(2));
+ assert_eq!(MILLISECONDS_IN_DAY as i32 + 1, actual.value(3));
+
+ let actual = date_part(&input, DatePart::Second).unwrap();
+ let actual = actual.as_primitive::<Int32Type>();
+ assert_eq!(0, actual.value(0));
+ assert_eq!(0, actual.value(1));
+ assert_eq!(1, actual.value(2));
+ assert_eq!(24 * 60 * 60, actual.value(3));
+
+ let actual = date_part(&input, DatePart::Minute).unwrap();
+ let actual = actual.as_primitive::<Int32Type>();
+ assert_eq!(0, actual.value(0));
+ assert_eq!(0, actual.value(1));
+ assert_eq!(0, actual.value(2));
+ assert_eq!(24 * 60, actual.value(3));
+
+ let actual = date_part(&input, DatePart::Hour).unwrap();
+ let actual = actual.as_primitive::<Int32Type>();
+ assert_eq!(0, actual.value(0));
+ assert_eq!(0, actual.value(1));
+ assert_eq!(0, actual.value(2));
+ assert_eq!(24, actual.value(3));
+
+ // Month and year are not valid (since days in month varies).
+ assert!(date_part(&input, DatePart::Month).is_err());
+ assert!(date_part(&input, DatePart::Year).is_err());
+ }
+
+ #[test]
+ fn test_interval_month_day_nano_array() {
+ let input: IntervalMonthDayNanoArray = vec![
+ IntervalMonthDayNano::ZERO,
+ IntervalMonthDayNano::new(5, 10, 42),
+ IntervalMonthDayNano::new(16, 35, MILLISECONDS_IN_DAY * 1_000_000
+ 1),
+ ]
+ .into();
+
+ // Year and month follow from month, but are not affected by days or
nanos.
+ let actual = date_part(&input, DatePart::Year).unwrap();
+ let actual = actual.as_primitive::<Int32Type>();
+ assert_eq!(0, actual.value(0));
+ assert_eq!(0, actual.value(1));
+ assert_eq!(1, actual.value(2));
+
+ let actual = date_part(&input, DatePart::Month).unwrap();
+ let actual = actual.as_primitive::<Int32Type>();
+ assert_eq!(0, actual.value(0));
+ assert_eq!(5, actual.value(1));
+ assert_eq!(16, actual.value(2));
+
+ // Week and day follow from day, but are not affected by months or
nanos.
+ let actual = date_part(&input, DatePart::Week).unwrap();
+ let actual = actual.as_primitive::<Int32Type>();
+ assert_eq!(0, actual.value(0));
+ assert_eq!(1, actual.value(1));
+ assert_eq!(5, actual.value(2));
+
+ let actual = date_part(&input, DatePart::Day).unwrap();
+ let actual = actual.as_primitive::<Int32Type>();
+ assert_eq!(0, actual.value(0));
+ assert_eq!(10, actual.value(1));
+ assert_eq!(35, actual.value(2));
+
+ // Times follow from nanos, but are not affected by months or dats.
Review Comment:
Proposed to fix in https://github.com/apache/arrow-rs/pull/6140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
