Dandandan commented on a change in pull request #9595:
URL: https://github.com/apache/arrow/pull/9595#discussion_r586686916
##########
File path: rust/datafusion/src/physical_plan/hash_join.rs
##########
@@ -311,6 +319,7 @@ fn update_hash(
hash: &mut JoinHashMap,
offset: usize,
random_state: &RandomState,
+ hashes_buffer: &mut Vec<u64>,
Review comment:
Indeed, this change is for reusing the allocated `Vec`.
Yes, makes sense to group them in a struct. There are some opportunities in
other functions "build_join_indexes" "build_batch", etc. for this as well. Not
sure if it makes sense they all receive the same struct, or maybe all of them a
subset of the most commonly needed parts :thinking:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
