nealrichardson commented on a change in pull request #9610: URL: https://github.com/apache/arrow/pull/9610#discussion_r586818018
########## File path: r/R/dataset-partition.R ########## @@ -76,7 +76,9 @@ HivePartitioning$create <- dataset___HivePartitioning #' calling `hive_partition()` with no arguments. #' @examples #' \donttest{ -#' hive_partition(year = int16(), month = int8()) +#' if (arrow_with_dataset()) { Review comment: I don't feel strongly about not requiring dev roxygen, but it's fine either way. If you don't want to use examplesIf here, I think you can leave off the `if (arrow_with_dataset())` checks everywhere since it's already inside a `\donttest` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org