danepitkin commented on code in PR #43311:
URL: https://github.com/apache/arrow/pull/43311#discussion_r1695638379
##########
java/dev/checkstyle/checkstyle.xml:
##########
@@ -48,9 +48,7 @@
<property name="file" value="${checkstyle.suppressions.file}"/>
</module>
- <module name="NewlineAtEndOfFile">
- <property name="lineSeparator" value="lf" />
Review Comment:
Good call, I should fix this properly.
The windows build was always generating windows line separators. There was a
bug in the old version of checkstyle that couldn't differentiate between \lf
and \cr\lf, so this was never caught before.
https://github.com/checkstyle/checkstyle/issues/4074
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
