chloro-pn commented on PR #6154: URL: https://github.com/apache/arrow-rs/pull/6154#issuecomment-2256691485
From the documentation of `gc`, it appears to do at least two things: * Compress `data buffer` (expensive) * Clean up the `buffers` based on the view list (cheap) The modification of this PR does not perform expensive operations of compressing `data buffers`, it only releases the reference count of `buffers` that no longer need to be held (the resources held by `buffers` are managed based on Arc's reference counting mechanism) So this PR cannot completely solve the problem you mentioned above (because compared to the `gc` method, it only does the less expensive part, for example, if all the `buffer` in the `buffers` hold different parts of the same `Bytes`, then this PR is meaningless because `Byte` will always be held), but it also does not introduce expensive overhead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
