bkietz commented on issue #43422: URL: https://github.com/apache/arrow/issues/43422#issuecomment-2258655834
> libarrow_testing.so depends on GoogleTest. If we always depend on our vendored GoogleTest, users can't mix system GoogleTest and libarrow_testing.so That's a good point; I had forgotten arrow_testing and it invalidates "we don't install anything which is linked to it anyway" in the issue description. `arrow_testing` is even [documented as installed.](https://github.com/bkietz/arrow/blob/7aea8bf7a65d679bd71d973b358f997eb3b6c6af/docs/source/cpp/build_system.rst?plain=1#L131) I'm not sure who uses it outside the arrow repository (maybe nobody does and it is only installed because `add_arrow_lib` doesn't have a `DONT_INSTALL` option), but in order to vendor GTest we'd need to deprecate installing that target first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
