CurtHagenlocher commented on code in PR #2043:
URL: https://github.com/apache/arrow-adbc/pull/2043#discussion_r1697648385
##########
csharp/src/Drivers/BigQuery/BigQueryStatement.cs:
##########
@@ -58,9 +58,9 @@ public override QueryResult ExecuteQuery()
GetQueryResultsOptions getQueryResultsOptions = new
GetQueryResultsOptions();
- if (this.Options != null &&
this.Options.ContainsKey(BigQueryParameters.GetQueryResultsOptionsTimeoutMinutes))
+ if
(this.Options!.TryGetValue(BigQueryParameters.GetQueryResultsOptionsTimeoutMinutes,
out string? timeoutMinutes))
Review Comment:
I don't think the null-forgiving operator is what's wanted here. At this
line of code, this.Options might well be null in which case this will throw. I
think what's wanted instead is `if (this.Options?.TryGetValue(...) == true)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
