jonkeane commented on issue #43317:
URL: https://github.com/apache/arrow/issues/43317#issuecomment-2260628757
I've also tried to replicate the CRAN devel image locally (I'll push a PR up
with that for CI after this fire drill). After Kou's change, we get past LZ4.
But then it seems to fail with the following. This isn't related directly to
the LZ4 change I don't think, and as far as I could tell on github that abseil
code hasn't changed in years. This could be a false positive, since I don't
have an exact replica of the CRAN runner, but wonder if anyone has any ideas
about what this might be.
```
[ 55%] Building CXX object
absl/strings/CMakeFiles/str_format_internal.dir/internal/str_format/extension.cc.o
-- stderr output is:
...skipping to end...
230e44/absl_ep-prefix/src/absl_ep/absl/strings/internal/str_format/extension.cc:45:1:
note: in expansion of macro ‘ABSL_INTERNAL_CONVERSION_CHARS_EXPAND_’
45 | ABSL_INTERNAL_CONVERSION_CHARS_EXPAND_(ABSL_INTERNAL_CHAR_SET_CASE, )
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/RtmpabvneB/file7a47e230e44/absl_ep-prefix/src/absl_ep/absl/strings/internal/str_format/extension.cc:44:13:
error: ‘FormatConversionCharSet’ does not name a type; did you mean
‘FormatConversionCharInternal’?
44 | constexpr FormatConversionCharSet
FormatConversionCharSetInternal::c;
| ^~~~~~~~~~~~~~~~~~~~~~~
/tmp/RtmpabvneB/file7a47e230e44/absl_ep-prefix/src/absl_ep/absl/strings/internal/str_format/extension.h:167:3:
note: in expansion of macro ‘ABSL_INTERNAL_CHAR_SET_CASE’
167 | X_VAL(g) X_SEP X_VAL(G) X_SEP X_VAL(a) X_SEP X_VAL(A) X_SEP \
| ^~~~~
/tmp/RtmpabvneB/file7a47e230e44/absl_ep-prefix/src/absl_ep/absl/strings/internal/str_format/extension.cc:45:1:
note: in expansion of macro ‘ABSL_INTERNAL_CONVERSION_CHARS_EXPAND_’
45 | ABSL_INTERNAL_CONVERSION_CHARS_EXPAND_(ABSL_INTERNAL_CHAR_SET_CASE, )
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/RtmpabvneB/file7a47e230e44/absl_ep-prefix/src/absl_ep/absl/strings/internal/str_format/extension.cc:44:13:
error: ‘FormatConversionCharSet’ does not name a type; did you mean
‘FormatConversionCharInternal’?
44 | constexpr FormatConversionCharSet
FormatConversionCharSetInternal::c;
| ^~~~~~~~~~~~~~~~~~~~~~~
/tmp/RtmpabvneB/file7a47e230e44/absl_ep-prefix/src/absl_ep/absl/strings/internal/str_format/extension.h:167:18:
note: in expansion of macro ‘ABSL_INTERNAL_CHAR_SET_CASE’
167 | X_VAL(g) X_SEP X_VAL(G) X_SEP X_VAL(a) X_SEP X_VAL(A) X_SEP \
| ^~~~~
/tmp/RtmpabvneB/file7a47e230e44/absl_ep-prefix/src/absl_ep/absl/strings/internal/str_format/extension.cc:45:1:
note: in expansion of macro ‘ABSL_INTERNAL_CONVERSION_CHARS_EXPAND_’
45 | ABSL_INTERNAL_CONVERSION_CHARS_EXPAND_(ABSL_INTERNAL_CHAR_SET_CASE, )
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/RtmpabvneB/file7a47e230e44/absl_ep-prefix/src/absl_ep/absl/strings/internal/str_format/extension.cc:44:13:
error: ‘FormatConversionCharSet’ does not name a type; did you mean
‘FormatConversionCharInternal’?
44 | constexpr FormatConversionCharSet
FormatConversionCharSetInternal::c;
| ^~~~~~~~~~~~~~~~~~~~~~~
/tmp/RtmpabvneB/file7a47e230e44/absl_ep-prefix/src/absl_ep/absl/strings/internal/str_format/extension.h:167:33:
note: in expansion of macro ‘ABSL_INTERNAL_CHAR_SET_CASE’
167 | X_VAL(g) X_SEP X_VAL(G) X_SEP X_VAL(a) X_SEP X_VAL(A) X_SEP \
| ^~~~~
/tmp/RtmpabvneB/file7a47e230e44/absl_ep-prefix/src/absl_ep/absl/strings/internal/str_format/extension.cc:45:1:
note: in expansion of macro ‘ABSL_INTERNAL_CONVERSION_CHARS_EXPAND_’
45 | ABSL_INTERNAL_CONVERSION_CHARS_EXPAND_(ABSL_INTERNAL_CHAR_SET_CASE, )
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/RtmpabvneB/file7a47e230e44/absl_ep-prefix/src/absl_ep/absl/strings/internal/str_format/extension.cc:44:13:
error: ‘FormatConversionCharSet’ does not name a type; did you mean
‘FormatConversionCharInternal’?
44 | constexpr FormatConversionCharSet
FormatConversionCharSetInternal::c;
| ^~~~~~~~~~~~~~~~~~~~~~~
/tmp/RtmpabvneB/file7a47e230e44/absl_ep-prefix/src/absl_ep/absl/strings/internal/str_format/extension.h:167:48:
note: in expansion of macro ‘ABSL_INTERNAL_CHAR_SET_CASE’
167 | X_VAL(g) X_SEP X_VAL(G) X_SEP X_VAL(a) X_SEP X_VAL(A) X_SEP \
| ^~~~~
/tmp/RtmpabvneB/file7a47e230e44/absl_ep-prefix/src/absl_ep/absl/strings/internal/str_format/extension.cc:45:1:
note: in expansion of macro ‘ABSL_INTERNAL_CONVERSION_CHARS_EXPAND_’
45 | ABSL_INTERNAL_CONVERSION_CHARS_EXPAND_(ABSL_INTERNAL_CHAR_SET_CASE, )
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/RtmpabvneB/file7a47e230e44/absl_ep-prefix/src/absl_ep/absl/strings/internal/str_format/extension.cc:44:13:
error: ‘FormatConversionCharSet’ does not name a type; did you mean
‘FormatConversionCharInternal’?
44 | constexpr FormatConversionCharSet
FormatConversionCharSetInternal::c;
| ^~~~~~~~~~~~~~~~~~~~~~~
/tmp/RtmpabvneB/file7a47e230e44/absl_ep-prefix/src/absl_ep/absl/strings/internal/str_format/extension.h:169:3:
note: in expansion of macro ‘ABSL_INTERNAL_CHAR_SET_CASE’
169 | X_VAL(n) X_SEP X_VAL(p)
| ^~~~~
/tmp/RtmpabvneB/file7a47e230e44/absl_ep-prefix/src/absl_ep/absl/strings/internal/str_format/extension.cc:45:1:
note: in expansion of macro ‘ABSL_INTERNAL_CONVERSION_CHARS_EXPAND_’
45 | ABSL_INTERNAL_CONVERSION_CHARS_EXPAND_(ABSL_INTERNAL_CHAR_SET_CASE, )
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/RtmpabvneB/file7a47e230e44/absl_ep-prefix/src/absl_ep/absl/strings/internal/str_format/extension.cc:44:13:
error: ‘FormatConversionCharSet’ does not name a type; did you mean
‘FormatConversionCharInternal’?
44 | constexpr FormatConversionCharSet
FormatConversionCharSetInternal::c;
| ^~~~~~~~~~~~~~~~~~~~~~~
/tmp/RtmpabvneB/file7a47e230e44/absl_ep-prefix/src/absl_ep/absl/strings/internal/str_format/extension.h:169:18:
note: in expansion of macro ‘ABSL_INTERNAL_CHAR_SET_CASE’
169 | X_VAL(n) X_SEP X_VAL(p)
| ^~~~~
/tmp/RtmpabvneB/file7a47e230e44/absl_ep-prefix/src/absl_ep/absl/strings/internal/str_format/extension.cc:45:1:
note: in expansion of macro ‘ABSL_INTERNAL_CONVERSION_CHARS_EXPAND_’
45 | ABSL_INTERNAL_CONVERSION_CHARS_EXPAND_(ABSL_INTERNAL_CHAR_SET_CASE, )
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/RtmpabvneB/file7a47e230e44/absl_ep-prefix/src/absl_ep/absl/strings/internal/str_format/extension.cc:49:11:
error: ‘FormatConversionCharSet’ does not name a type; did you mean
‘FormatConversionCharInternal’?
49 | constexpr FormatConversionCharSet
FormatConversionCharSetInternal::kStar;
| ^~~~~~~~~~~~~~~~~~~~~~~
| FormatConversionCharInternal
/tmp/RtmpabvneB/file7a47e230e44/absl_ep-prefix/src/absl_ep/absl/strings/internal/str_format/extension.cc:51:11:
error: ‘FormatConversionCharSet’ does not name a type; did you mean
‘FormatConversionCharInternal’?
51 | constexpr FormatConversionCharSet
FormatConversionCharSetInternal::kIntegral;
| ^~~~~~~~~~~~~~~~~~~~~~~
| FormatConversionCharInternal
/tmp/RtmpabvneB/file7a47e230e44/absl_ep-prefix/src/absl_ep/absl/strings/internal/str_format/extension.cc:53:11:
error: ‘FormatConversionCharSet’ does not name a type; did you mean
‘FormatConversionCharInternal’?
53 | constexpr FormatConversionCharSet
FormatConversionCharSetInternal::kFloating;
| ^~~~~~~~~~~~~~~~~~~~~~~
| FormatConversionCharInternal
/tmp/RtmpabvneB/file7a47e230e44/absl_ep-prefix/src/absl_ep/absl/strings/internal/str_format/extension.cc:55:11:
error: ‘FormatConversionCharSet’ does not name a type; did you mean
‘FormatConversionCharInternal’?
55 | constexpr FormatConversionCharSet
FormatConversionCharSetInternal::kNumeric;
| ^~~~~~~~~~~~~~~~~~~~~~~
| FormatConversionCharInternal
/tmp/RtmpabvneB/file7a47e230e44/absl_ep-prefix/src/absl_ep/absl/strings/internal/str_format/extension.cc:57:11:
error: ‘FormatConversionCharSet’ does not name a type; did you mean
‘FormatConversionCharInternal’?
57 | constexpr FormatConversionCharSet
FormatConversionCharSetInternal::kPointer;
| ^~~~~~~~~~~~~~~~~~~~~~~
| FormatConversionCharInternal
make[5]: ***
[absl/strings/CMakeFiles/str_format_internal.dir/build.make:104:
absl/strings/CMakeFiles/str_format_internal.dir/internal/str_format/extension.cc.o]
Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [CMakeFiles/Makefile2:2382:
absl/strings/CMakeFiles/str_format_internal.dir/all] Error 2
make[3]: *** [Makefile:136: all] Error 2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]