alamb commented on PR #6181: URL: https://github.com/apache/arrow-rs/pull/6181#issuecomment-2265522354
> I wonder if tests regarding my changes should be added in tests/arrow_reader/statistics.rs. Yes, please do add tests there (as that actually tests both data pages and row group statistics) Also, when testing StringView in general it is important to include strings that are also greater than 12 bytes in length as the internal representation is differed for strings shorter and longer than that length -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
