alamb commented on PR #6178: URL: https://github.com/apache/arrow-rs/pull/6178#issuecomment-2265595877
> The current issue is that `criterion` [cannot test private members in the module](https://bheisler.github.io/criterion.rs/book/user_guide/known_limitations.html), so I have to set some members in `filter.rs` to public or provide access interfaces, which may not be the best practice. Perhaps you could add some cases to https://github.com/apache/arrow-rs/blob/master/arrow/benches/filter_kernels.rs rather than a new benchmark? I think that has a pretty good setup for testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
