paleolimbot commented on code in PR #555:
URL: https://github.com/apache/arrow-nanoarrow/pull/555#discussion_r1702428450
##########
src/nanoarrow/ipc/encoder.c:
##########
@@ -27,31 +27,36 @@
#define ns(x) FLATBUFFERS_WRAP_NAMESPACE(org_apache_arrow_flatbuf, x)
-#define FLATCC_RETURN_UNLESS_0(x) \
- if (ns(x) != 0) return ENOMEM;
+#define FLATCC_RETURN_UNLESS_0_NO_NS(x) \
+ if ((x) != 0) { \
+ ArrowErrorSet(error, "%s:%d: %s failed", __FILE__, __LINE__, #x); \
Review Comment:
Even though `ArrowError*` is usually called `error`, there is some prior art
that uses a macro argument to handle this elsewhere (e.g.,
`NANOARROW_RETURN_NOT_OK_WITH_ERROR()`). (I wasn't sure the error was getting
updated when reading the below code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
